Repository navigation
syscall: skip unsupported symlink chmod - #1148
Conversation
|
@ckujau please test |
|
Thanks so much for doing this. I owe you. While the patch itself was fairly straightforward, I will admit that the needed test was definitely slowing me down. I'm making a close study of yours in anticipation of possible future need. I've run this patch though a variety of stress tests (using 6 different architectures), including the example given by @ckujau as well as a complete transfer of an OpenBSD system to Debian13. The latter was done with both version 3.5.2 (which produced many "unsupported" errors) and with this patch (which ran completely clean). Hopefully @ckujau will have the same results. I've added to latter test to my regular checklist. Sorry to have created the need for this patch. Thanks again. Take care. |
|
Sorry for the delay, I did not expect fix to be available this quickly :-) Yes, with that commit applied, the error is indeed gone. I can copy symlinks off *BSD systems again, w/o that error message. Thank you for fixing this so quickly! Don't know if you do these around here, but feel free to add: Tested-by: Christian Kujau lists@nerdbynature.de |
|
Thank you for the confirmation. |
Vendored tooling that some agents keep in their config trees is not session
data (69 MB of clio/opencode's 1.6 GB), and it holds most of the symlinks
in a Mac agent's tree. The test pins the flag in the exact-argv assertion
and checks that node_modules never arrives.
-p stays. The nightly exit 23 on macOS sources ("failed to set permissions
... Operation not supported (95)" on symlinks) is an rsync 3.5.2 receiver
bug, fixed on vulcan by running the patched rsync-mac-receiver build
(RsyncProject/rsync#1148, nixos-config f1804b6d) rather than by dropping
permission preservation here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #1147
Summary
Restores the skipped-operation result when no-follow symlink chmod is unsupported. Batch-replay regression for non-0777 symlink modes, covering new and existing normal and dangling links and checking that target permissions and contents remain unchanged.